RFR 8199603: Build failures after JDK-8199421 "Add support for vector popcount"

Aleksey Shipilev shade at redhat.com
Wed Mar 14 11:33:52 UTC 2018


Thanks Tobias,

With your Reviewer hat on, you consider this trivial? Should I push it now?

-Aleksey

On 03/14/2018 12:30 PM, Tobias Hartmann wrote:
> Hi Aleksey,
> 
> looks good to me!
> 
> Best regards,
> Tobias
> 
> On 14.03.2018 12:18, Aleksey Shipilev wrote:
>> Bug:
>>   https://bugs.openjdk.java.net/browse/JDK-8199603
>>
>> Fix:
>>   http://cr.openjdk.java.net/~shade/8199603/webrev.01/
>>
>> The problem with the offending change was that the declaration for vpopcntd comes in shared 32/64
>> assembler, but definition is in 64 assembler only. Assembler method is being used from shared 32/64
>> x86.ad, so the simplest fix is moving the definition close to shared 32/64, near existing popcntl.
>>
>> Testing: x86_32 build, x86_64 compiler/vectorization/TestPopCountVector test
>> (can run it through submit-hs, but I think it is too trivial to bother)
>>
>> Thanks,
>> -Aleksey
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180314/443306ff/signature.asc>


More information about the hotspot-compiler-dev mailing list