RFR(xxs): 8200297: Build failures after JDK-8198691 (CodeHeap State Analytics)

[Schmidt, Lutz]

Dear all,

first of all a big THANK YOU to all involved for detecting, handling and fixing this issue. I was in really bad shape yesterday.

Regards,
Lutz

From: hotspot-compiler-dev <hotspot-compiler-dev-bounces at openjdk.java.net> on behalf of Thomas Stüfe <thomas.stuefe at gmail.com>
Date: Wednesday, 28. March 2018 at 09:18
To: Vladimir Kozlov <vladimir.kozlov at oracle.com>
Cc: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
Subject: Re: RFR(xxs): 8200297: Build failures after JDK-8198691 (CodeHeap State Analytics)

Hi,

On Tue, Mar 27, 2018 at 10:18 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com<mailto:vladimir.kozlov at oracle.com>> wrote:
On 3/27/18 12:34 PM, Thomas Stüfe wrote:


On Tue, Mar 27, 2018 at 9:03 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com<mailto:vladimir.kozlov at oracle.com> <mailto:vladimir.kozlov at oracle.com<mailto:vladimir.kozlov at oracle.com>>> wrote:

    Looks good to me too.

    But it should be verified by someone. Our (Oracle) Java test system
    and submit-hs (which use it) does not build or test on any x86_32
    systems.


Well, I did build on Linux 32bit. Is that sufficient or do you need someone else to test?

If you can run HelloWorld.java with -Xlog:codecache=Trace to use stat code, it will be sufficient for me.

Thanks,
Vladimir


Tested on ubuntu 16.4 32bit. Looks good. Pushed.

Thanks, Thomas



Thanks, Thomas

    Regards,
    Vladimir


    On 3/27/18 8:31 AM, Aleksey Shipilev wrote:

        On 03/27/2018 05:27 PM, Thomas Stüfe wrote:

            http://cr.openjdk.java.net/~stuefe/webrevs/8200297-builderrors-on-x86-32-after-codeheap-lucy/webrev.01/webrev/
            <http://cr.openjdk.java.net/~stuefe/webrevs/8200297-builderrors-on-x86-32-after-codeheap-lucy/webrev.01/webrev/>


        OK from me, assuming it still builds x86_32, and passes submit-hs.

        Thanks,
        -Aleksey


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180328/179e0d68/attachment.html>