RFR(M): 8200303: C2 should leverage profiling for lookupswitch/tableswitch

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Mar 28 21:12:00 UTC 2018


Hi Roland,

I filed 8200383 [1] and sent fix for review. With that fix you don't 
need to include math.h - build passed with webrev.00 version.

I think you need an other Reviewer to look on your changes.

Thanks,
Vladimir

[1] https://bugs.openjdk.java.net/browse/JDK-8200383

On 3/28/18 12:26 PM, Vladimir Kozlov wrote:
> We do link with /lib/sparcv9/libm.so.1 but it does not have log2f() :(
> 
> http://hg.openjdk.java.net/jdk/hs/file/6d5bd76650df/make/autoconf/libraries.m4#l116 
> 
> 
> I will file a bug.
> 
> Vladimir
> 
> On 3/28/18 11:26 AM, Vladimir Kozlov wrote:
>> Did not help :(
>>
>> Some kind of linker weirdness:
>>
>> log2f 
>> workspace/build/solaris-sparcv9-debug/hotspot/variant-server/libjvm/objs/parse2.o 
>>   (symbol belongs to implicit dependency 
>> /work_dir/jib-master/install/jpg/infra/builddeps/devkit-solaris_sparcv9/SS12u4-Solaris11u1+1.1/devkit-solaris_sparcv9-SS12u4-Solaris11u1+1.1.tar.gz/SS12u4-Solaris11u1/sysroot/usr/lib/sparcv9/libm.so.2) 
>>
>>
>> Vladimir
>>
>> On 3/28/18 12:42 AM, Roland Westrelin wrote:
>>>
>>> Hi Vladimir,
>>>
>>> Thanks for helping again.
>>>
>>>> Failed to build on SPARC (PCH?):
>>>>
>>>> Undefined            first referenced
>>>> symbol                  in file
>>>> log2f
>>>> /workspace/build/solaris-sparcv9/hotspot/variant-server/libjvm/objs/parse2.o 
>>>>
>>>
>>> It builds fine without precompiled headers on linux.
>>>
>>> I added a:
>>>
>>> #include <math.h>
>>>
>>> http://cr.openjdk.java.net/~roland/8200303/webrev.01/
>>>
>>> Can you try that one?
>>>
>>> Roland.
>>>


More information about the hotspot-compiler-dev mailing list