RFR: 8202640: Small C1 cleanups for BarrierSetC1
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri May 4 23:58:25 UTC 2018
Okay.
Thanks,
Vladimir
On 5/4/18 12:42 PM, Erik Osterlund wrote:
> Hi Vladimir,
>
> Thank you for reviewing.
> This change does not change anything for any other platforms. So I do not think RH and SAP needs to try this change.
>
> Thanks,
> /Erik
>
>> On 4 May 2018, at 19:18, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> Hi Erik,
>>
>> changes look reasonable. Should you change other platforms too since you changed API? At least asks RH and SAP test these changes.
>>
>> Thanks,
>> Vladimir
>>
>>> On 5/4/18 2:33 AM, Erik Österlund wrote:
>>> Hi,
>>> After rebasing ZGC to BarrierSetC1, we noticed a few small cleanups that would be great.
>>> * restore_live_registers_except_rax should be exposed so that barrier set backends may use it
>>> * save_live_registers_no_oop_map has an unused argument that should be removed
>>> * LIR_OpVisitState::visit should allow visiting LIR with a virtual call (for GC barrier LIR_Ops).
>>> * LIR_List::append ought to be public so that barrier set backends can add barrier LIR_Ops.
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8202640
>>> Webrev:
>>> http://cr.openjdk.java.net/~eosterlund/8202640/webrev.00/
>>> Thanks,
>>> /Erik
>
More information about the hotspot-compiler-dev
mailing list