RFR: 8202711: Merge tiered compilation policies

Claes Redestad claes.redestad at oracle.com
Tue May 8 20:56:49 UTC 2018


Renaming and moving only SimpleThresholdPolicy (to 
TieredCompilationPolicy?) seems trivial, since it's only
included and used directly from compilationPolicy.cpp

... if we are to move compilationPolicy.* from runtime/ to compiler/, 
then that touches 15+ source files,
so might be a bit of a rabbit hole.

My gut feeling is still that it's better to do it separately.

/Claes

On 2018-05-08 22:09, Igor Veresov wrote:
> Should we do the renaming of the policy right away?
>
> igor
>
>> On May 8, 2018, at 9:27 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>
>> On 5/8/18 1:12 AM, Claes Redestad wrote:
>>> On 2018-05-07 22:53, Vladimir Kozlov wrote:
>>>>>> After these changes there is no difference between CompilationPolicyChoice 2 and 3. Why you kept both?
>>>>> Would you prefer if the CompilationPolicyChoice == 2 case did an Unimplemented() as if TIERED
>>>>> wasn't defined in the build?
>>>> I want to remove == 3 at all. Limit flag to 0,1,2 values. Where 2 is default and only option for Tiered.
>>> Ok: http://cr.openjdk.java.net/~redestad/8202711/open.01/
>> Looks good to me. Please, run mach5 before push.
>>
>>> CSR needed..?
>> I think we can skip CSR because "fortunately" this flag is not documented in Java documents or release notes.
>>
>> Vladimir
>>
>>> /Claes



More information about the hotspot-compiler-dev mailing list