RFR(XS): 8132287: obsolete the "InlineNotify" flag option

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu May 10 16:43:40 UTC 2018


Looks good.

Only concern is that library_call.cpp does not include 
objectMonitor.hpp. You need to verify build without pre-compiled header 
file.

Thanks,
Vladimir

On 5/10/18 6:52 AM, Daniel D. Daugherty wrote:
> Greetings,
> 
> This review has been sent to two aliases so please reply to both.
> 
> I'm obsoleting the '-XX:+InlineNotify' option and moving its functionality
> to the experimental '-XX:SyncKnobs' option. This is a leftover cleanup from
> the "Contended Locking fast notify bucket".
> 
> Since this is a diagnostic option, a CSR is not required:
> 
> https://wiki.openjdk.java.net/display/csr/CSR+FAQs
> 
>  > Interfaces that are experimental or for diagnostic purposes do not need
>  > to go through CSR process, but the CSR process may be employed if 
> feedback
>  > from the CSR reviewers is desired.
> 
> Webrev URL: 
> http://cr.openjdk.java.net/~dcubed/8132287-webrev/0_for_jdk_jdk/
> 
> See the bug for the results of test invocations of the '-XX:+InlineNotify'
> option and the new '-XX:SyncKnobs' suboption.
> 
> Thanks, in advance, for any feedback.
> 
> Dan


More information about the hotspot-compiler-dev mailing list