RFR(XS): 8132287: obsolete the "InlineNotify" flag option

[Daniel D. Daugherty]

Answering my own question:

Exception in thread "main" jdk.vm.ci.common.JVMCIError: expected VM flag 
not found: InlineNotify
     at 
jdk.internal.vm.ci/jdk.vm.ci.hotspot.HotSpotVMConfigAccess.getFlag(HotSpotVMConfigAccess.java:288)
     at 
jdk.internal.vm.ci/jdk.vm.ci.hotspot.HotSpotVMConfigAccess.getFlag(HotSpotVMConfigAccess.java:264)
     at 
jdk.internal.vm.compiler at 11-internal/org.graalvm.compiler.hotspot.GraalHotSpotVMConfigVersioned.<init>(GraalHotSpotVMConfigVersioned.java:47)
     at 
jdk.internal.vm.compiler at 11-internal/org.graalvm.compiler.hotspot.GraalHotSpotVMConfigBase.<init>(GraalHotSpotVMConfigBase.java:40)
     at 
jdk.internal.vm.compiler at 11-internal/org.graalvm.compiler.hotspot.GraalHotSpotVMConfig.<init>(GraalHotSpotVMConfig.java:40)
     at 
jdk.internal.vm.compiler at 11-internal/org.graalvm.compiler.hotspot.AOTGraalHotSpotVMConfig.<init>(AOTGraalHotSpotVMConfig.java:34)
     at 
jdk.internal.vm.compiler at 11-internal/org.graalvm.compiler.hotspot.HotSpotGraalRuntime.<init>(HotSpotGraalRuntime.java:138)
     at 
jdk.internal.vm.compiler at 11-internal/org.graalvm.compiler.hotspot.HotSpotGraalCompilerFactory.createCompiler(HotSpotGraalCompilerFactory.java:143)
     at jdk.aot/jdk.tools.jaotc.Main.run(Main.java:144)
     at jdk.aot/jdk.tools.jaotc.Main.run(Main.java:101)
     at jdk.aot/jdk.tools.jaotc.Main.main(Main.java:80)

Tier1 test failures!

Vladimir or Dean, I have no idea how to fix this (yet).

Dan


On 5/10/18 2:52 PM, Daniel D. Daugherty wrote:
> Hi Dean!
>
> Thanks for reviewing.
>
> This is a flag that is default true and I'm not aware of anyone outside
> of me or Dave Dice that uses it. The flag is not removed (yet), it is
> simply ignored (with a warning) so what will break in Graal in this
> situation?
>
> I believe the normal Graal protocol is to make changes upstream and they
> land in jdk/jdk when Vladimir does a sync-down. Not knowing Graal at all,
> I have no idea if Graal knows about '-XX:SyncKnobs' or even if it 
> should...
>
> Dan
>
>
> On 5/10/18 2:44 PM, dean.long at oracle.com wrote:
>> I believe we'll need a fix for Graal so it doesn't break.
>>
>> http://hg.openjdk.java.net/jdk/jdk/file/tip/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java#l47 
>>
>>
>> dl
>>
>> On 5/10/18 6:52 AM, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> This review has been sent to two aliases so please reply to both.
>>>
>>> I'm obsoleting the '-XX:+InlineNotify' option and moving its 
>>> functionality
>>> to the experimental '-XX:SyncKnobs' option. This is a leftover 
>>> cleanup from
>>> the "Contended Locking fast notify bucket".
>>>
>>> Since this is a diagnostic option, a CSR is not required:
>>>
>>> https://wiki.openjdk.java.net/display/csr/CSR+FAQs
>>>
>>> > Interfaces that are experimental or for diagnostic purposes do not 
>>> need
>>> > to go through CSR process, but the CSR process may be employed if 
>>> feedback
>>> > from the CSR reviewers is desired.
>>>
>>> Webrev URL: 
>>> http://cr.openjdk.java.net/~dcubed/8132287-webrev/0_for_jdk_jdk/
>>>
>>> See the bug for the results of test invocations of the 
>>> '-XX:+InlineNotify'
>>> option and the new '-XX:SyncKnobs' suboption.
>>>
>>> Thanks, in advance, for any feedback.
>>>
>>> Dan
>>
>
>