RFR(XS): 8132287: obsolete the "InlineNotify" flag option

Daniel D. Daugherty daniel.daugherty at oracle.com
Thu May 10 21:24:59 UTC 2018


A Mach5 builds-tier1,hs-tier1,hs-tier2 job with the following
additional changes (thanks Vladimir and Dean!) passes...

Still waiting for Runtime team review...

$ hg diff -r 8132287.cr0
diff -r cbeb21e5a2c6 src/hotspot/share/opto/library_call.cpp
--- a/src/hotspot/share/opto/library_call.cpp    Thu May 10 09:37:27 
2018 -0400
+++ b/src/hotspot/share/opto/library_call.cpp    Thu May 10 17:23:08 
2018 -0400
@@ -52,6 +52,7 @@
  #include "opto/subnode.hpp"
  #include "prims/nativeLookup.hpp"
  #include "prims/unsafe.hpp"
+#include "runtime/objectMonitor.hpp"
  #include "runtime/sharedRuntime.hpp"
  #ifdef TRACE_HAVE_INTRINSICS
  #include "trace/traceMacros.hpp"
diff -r cbeb21e5a2c6 
src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java
--- 
a/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java 
Thu May 10 09:37:27 2018 -0400
+++ 
b/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java 
Thu May 10 17:23:08 2018 -0400
@@ -44,7 +44,7 @@
      final boolean useCRC32CIntrinsics = getFlag("UseCRC32CIntrinsics", 
Boolean.class);

      // JDK-8075171
-    final boolean inlineNotify = getFlag("InlineNotify", Boolean.class);
+    final boolean inlineNotify = getFlag("InlineNotify", Boolean.class, 
true);

      // JDK-8046936
      final int javaThreadReservedStackActivationOffset = 
getFieldOffset("JavaThread::_reserved_stack_activation", Integer.class, 
"address");

On 5/10/18 3:55 PM, Daniel D. Daugherty wrote:
> On 5/10/18 3:52 PM, dean.long at oracle.com wrote:
>> On 5/10/18 12:19 PM, Daniel D. Daugherty wrote:
>>> I can include the Graal fix in my push if that works for you... 
>>
>> Yes, please do.  This should do it:
>
> Thanks! I'll take that change for a Mach5 spin in a few minutes...
>
> Dan
>
>
>>
>> diff -r 0509b9be3bda 
>> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java
>> --- 
>> a/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java 
>> Thu May 10 11:45:40 2018 -0700
>> +++ 
>> b/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java 
>> Thu May 10 12:50:48 2018 -0700
>> @@ -44,7 +44,7 @@
>>      final boolean useCRC32CIntrinsics = 
>> getFlag("UseCRC32CIntrinsics", Boolean.class);
>>
>>      // JDK-8075171
>> -    final boolean inlineNotify = getFlag("InlineNotify", 
>> Boolean.class);
>> +    final boolean inlineNotify = getFlag("InlineNotify", 
>> Boolean.class, true);
>>
>>      // JDK-8046936
>>      final int javaThreadReservedStackActivationOffset = 
>> getFieldOffset("JavaThread::_reserved_stack_activation", 
>> Integer.class, "address");
>>
>>
>> dl
>
>



More information about the hotspot-compiler-dev mailing list