RFR(XXS): jtnew TestFloatsOnStackDeopt.java test gets error on thread.stop call

Claes Redestad claes.redestad at oracle.com
Tue May 22 11:20:06 UTC 2018


Hi,


On 2018-05-22 13:04, Boris Ulasevich wrote:
> Hi all,
>
> Could you please review simple fix for the recently introduced test
>
> http://bugs.openjdk.java.net/browse/JDK-8203431
> http://cr.openjdk.java.net/~bulasevich/8203431/webrev.02

the use of a volatile boolean to signal the thread to stop along with 
Thread.join()
should be sufficient to make the test well-behaved. Thanks!

Nit: I'd prefer to see StringBuilder rather than StringBuffer, but don't 
think that
this change to avoid string concatenation is necessary in the first 
place either.

/Claes


More information about the hotspot-compiler-dev mailing list