RFR(S): 8202747: C2: assert(mode == ControlAroundStripMined && use == sfpt) failed: missed a node

Roland Westrelin rwestrel at redhat.com
Thu May 24 10:00:34 UTC 2018


Hi Nils,

> I would be nice to clarify the use of extra_data_nodes with a comment. I 
> know it was introduced in an earlier patch, but looking at just this 
> patch its function was not obvious. Add a comment or change the name to 
> something less generic.

I'll do that before I push it (unless you want to see another webrev?).

> Otherwise it looks good, thanks for fixing.

Thanks for the review.

> I am testing this together with 8203197 now.

Cool. Thanks.

Roland.


More information about the hotspot-compiler-dev mailing list