RFR[11]: 8184030: JDKJDK-8184030,,TestUseRTMLockingOptionOnUnsupportedVM - RTM locking optimization not supported is missing

Gustavo Romero gromero at linux.vnet.ibm.com
Thu May 24 17:50:57 UTC 2018


Hi Jamsheed,

On 05/24/2018 02:14 PM, jamsheed wrote:
> Thank you for the review, Gustavo.
> 
> this test checks for the specified string: jtreg/compiler/rtm/cli/TestUseRTMLockingOptionOnUnsupportedVM.java

Yup, on "...relying on that string" I meant the removed string
"...emulated client VM", not the one resulted from the change. So I meant
that replacing "emulated client VM" as in the proposed change won't break
any tests afaics :)


Best regards,
Gustavo
  
> Best regards,
> 
> Jamsheed
> 
> 
> On Thursday 24 May 2018 07:50 PM, Gustavo Romero wrote:
>> Hi Jamsheed
>>
>> LGTM too. I don't see any JTreg RTM tests relying on that string.
>>
>> I'm not a (R)eviewer tho. It just happens that I was working with the RTM
>> tests recently...
>>
>>
>> Best regards,
>> Gustavo
>>
>> On 05/24/2018 08:42 AM, Tobias Hartmann wrote:
>>> Hi Jamsheed,
>>>
>>> looks good.
>>>
>>> Thanks,
>>> Tobias
>>>
>>> On 24.05.2018 12:42, jamsheed wrote:
>>>> webrev: http://cr.openjdk.java.net/~jcm/8184030/webrev.00/
>>>>
>>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8184030
>>>>
>>>> request for review for the change, correction in unsupported message
>>>>
>>>> Best regards,
>>>>
>>>> Jamsheed
>>>>
>>>>
>>>
>>
> 



More information about the hotspot-compiler-dev mailing list