[8u] RFR for backport of JDK-8164920: ppc: enhancement of CRC32 intrinsic to jdk8u-dev

[Gustavo Romero]

Hi Goetz,

Do you have any recommendation about that CRC32 backport I sent some time ago?

http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2018-March/028582.html

Do you think it's feasible?

The more radical changes I did (to make it PPC64-only) was in your change "8086069".

The other changes a quite straightforward.


Best regards,
Gustavo

On 03/26/2018 06:37 PM, Gustavo Romero wrote:
> Hi Goetz, Lutz, and Hiroshi,
> 
> I would like to backport the CRC32 intrinsics [1,3] and so I've
> backported the following patchset necessary to accomplish that:
> 
> [0] 8086069: Adapt runtime calls to recent intrinsics to pass ints as long (Needed by 8131048. Changes in shared code were removed)
> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/8086069/v1/
> Author: goetz
> 
> [1] 8131048: ppc: implement CRC32 intrinsic
> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/8131048/v1/
> Author: lutz
> 
> [2] 8077838: Recent developments for ppc. (Just the implementation of has_vpmsumb() is needed by 8164920)
> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/8077838/v1/
> Author: goetz
> 
> [3] 8164920: ppc: enhancement of CRC32 intrinsic (Hiroshi's intrinsic for C2)
> http://cr.openjdk.java.net/~gromero/crc32_jdk8u/8164920/v1/
> Author: hiroshi
> 
> None applied cleanly so could you please review them? I kept them not
> squashed in order to ease the review. Please let me know if a single patch
> is better. The patchset is PPC64-only and I tested it on Linux PPC64 LE, so
> I need a help to test on AIX and Linux BE as well.
> 
> The bulk of changes are in [1] and [3].
> 
> I'm aware that SAP is heavily working on JDK11 right now but since the
> absence of the CRC32 intrinsics hurts workloads like Apache Cassandra
> I would be very glad if that change could make its way into jdk8u.
> 
> Thank you.
> 
> Best regards,
> Gustavo
> 
> [0] 8086069: Adapt runtime calls to recent intrinsics to pass ints as long (https://bugs.openjdk.java.net/browse/JDK-8086069)
> [1] 8131048: ppc: implement CRC32 intrinsic (https://bugs.openjdk.java.net/browse/JDK-8131048)
> [2] 8077838: Recent developments for ppc. (https://bugs.openjdk.java.net/browse/JDK-8077838)
> [3] 8164920: ppc: enhancement of CRC32 intrinsic (https://bugs.openjdk.java.net/browse/JDK-8164920)
>