[12] RFR(XXS): JDK-8196950: AARCH64 - Add VM flags presets for Cavium Thunder X2 CPU

[Andrew Dinn]

On 06/11/18 10:45, Dmitry Chuyko wrote:
> On 11/2/18 6:20 PM, Andrew Dinn wrote:
>> Hi Dmitry,
>>
>> On 02/11/18 14:01, Dmitry Chuyko wrote:
>>> On 11/1/18 12:47 PM, Andrew Dinn wrote:
>>>> On 31/10/18 17:40, Dmitry Chuyko wrote:
>>>> .............................
>>> That's an option. Though "default" (false) and "false" are not exactly
>>> the same, in the sense of explicitly expressing the difference in
>>> benchmarks score, we'll have history for that.
>> I am afraid don't know what that is supposed to mean. Can you try
>> explaining it again, perhaps in more detail?
>>
>>> Webrev with updated patch:
>>> http://cr.openjdk.java.net/~dchuyko/8198294/webrev.00/
>> Well, the patch now looks good to me. However, I'm not sure if your
>> comment means I need to revise that view. My belief is that:
>>
>> i) this is the better way to patch the code (because it removes
>> unnecessary code)
>>
>> ii) the result will be functionally /identical/ to that obtained using
>> the patch you initially suggested
>>
>> If your statement above is supposed to counter the second of those
>> beliefs is wrong I'd be glad to be corrected.
> 
> Andrew, thanks for the review. I definitely agree with both statements
> above.
> 
> OK to push?
Sure, please proceed.

n.b. you will need to update the copyright year before doing so.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander