RFR(S): 8205574: Loop predication "assert(f <= 1 && f >= 0) failed Incorrect frequency"

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Nov 8 17:23:01 UTC 2018


Okay. I was thinking about to have an other method check_frequency() which would return 'true' for 
windows and do check otherwise. But your code with verify_frequencies is fine too.

Vladimir

On 11/8/18 12:55 AM, Roland Westrelin wrote:
> 
> Hi Vladimir,
> 
> Thanks for looking at this.
> 
>> And remove asserts - they only test if fesetround() works correctly.
> 
> I don't agree with that part. There could be some bug in how frequencies
> from multiple paths are computed and it is nice to have some sanity
> checking.
> 
> Roland.
> 


More information about the hotspot-compiler-dev mailing list