RFR(XS) 8212221: GraalUnitTestLauncher should generate MX_SUBPROCESS_COMMAND_FILE

[dean.long at oracle.com]

Looks good.

dl

On 11/11/18 10:43 PM, Ekaterina Pavlova wrote:
> Thanks Dean for prompt review.
>
> I like your idea. Please see new webrev here:
>  http://cr.openjdk.java.net/~epavlova//8212221/webrev.01/
>
> New testing has been completed as well.
>
> thanks,
> -katya
>
> On 11/9/18 2:42 PM, dean.long at oracle.com wrote:
>> This looks good, but I'm concerned that the temp file might not get 
>> cleaned up at VM exit, because it is used by a sub-process.  You 
>> might want to instead create the file in the current test directory 
>> and let the test harness clean it up, like I did here:
>>
>> http://cr.openjdk.java.net/~dlong/8204521/webrev/
>>
>> dl
>>
>> On 11/9/18 2:24 PM, Ekaterina Pavlova wrote:
>>> Hi,
>>>
>>> Some graal unit tests rely on MX_SUBPROCESS_COMMAND_FILE env 
>>> variable which contains
>>> name of the file with java path and java args used to launch current 
>>> test process.
>>> This change creates such file and sets MX_SUBPROCESS_COMMAND_FILE 
>>> variable.
>>> Please review.
>>>
>>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8212221
>>>  webrev: 
>>> http://cr.openjdk.java.net/~epavlova//8212221/webrev.00/index.html
>>> testing: previously failed tests were removed from 
>>> ProblemList-graal.txt and executed as part of graal unit testing in 
>>> Mach5.
>>>
>>> thanks,
>>> -katya
>>>
>>
>