[12] RFR: 8212779: ADL Parser does not check allocation return values in all cases
Tobias Hartmann
tobias.hartmann at oracle.com
Fri Nov 16 08:23:22 UTC 2018
Hi Jamsheed,
looks good to me too.
Best regards,
Tobias
On 15.11.18 16:59, jamsheed wrote:
> Hi Vladimir,
>
> Thanks for the review! Changed the code with respect to the review comments.
>
> revised webrev is here: http://cr.openjdk.java.net/~jcm/8212779/webrev.01/
>
> Best regards
>
> Jamsheed
>
>
> On Wednesday 14 November 2018 11:56 PM, Vladimir Kozlov wrote:
>> Hi, Jamsheed
>>
>> In general it looks good.
>> You need to print a message on exit to easy diagnose a problem in a future.
>> Why you need RETURN_NULL if it is not used?
>>
>> Thanks,
>> Vladimir
>>
>> On 11/14/18 2:09 AM, jamsheed wrote:
>>> Hi,
>>>
>>> request to review malloc failure handling in adl parser.
>>>
>>> webrev: http://cr.openjdk.java.net/~jcm/8212779/webrev.00/
>>>
>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8212779
>>>
>>> Best regards,
>>>
>>> Jamsheed
>>>
>
More information about the hotspot-compiler-dev
mailing list