[12]RFR: 8211034: OnStackReplacePercentage option checking has bugs

[jamsheed]

Hi Vladimir,

found some issues with the code.

1) ProfileInterpreter on, doesn't use count_shift for limit computation.

2) 32 bit vm,  lower compile threshold value will overflow.

fixed both of them,

revised webrev: http://cr.openjdk.java.net/~jcm/8211034/webrev.03/

Best regards,

Jamsheed


On Wednesday 21 November 2018 10:20 PM, Vladimir Kozlov wrote:
> Good.
>
> Thanks,
> Vladimir
>
> On 11/21/18 6:59 AM, jamsheed wrote:
>> Hi Vladimir,
>>
>> agree. revised webrev: 
>> http://cr.openjdk.java.net/~jcm/8211034/webrev.01/
>>
>> Best regards,
>>
>> Jamsheed
>>
>>
>> On Wednesday 21 November 2018 01:24 AM, Vladimir Kozlov wrote:
>>> Hi Jamsheed,
>>>
>>> I think messages for over limit cases should be changed to use 
>>> max_percentage_limit.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 11/20/18 10:50 AM, jamsheed wrote:
>>>> Hi,
>>>>
>>>> Request for review the changes made in 
>>>> OnStackReplacePercentageConstraintFunc for overflow handling.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~jcm/8211034/webrev.00/
>>>>
>>>> jbs:https://bugs.openjdk.java.net/browse/JDK-8211034
>>>>
>>>> Best regards,
>>>>
>>>> Jamsheed
>>>>
>>