RFR(T): 8214451: PPC64/s390: Clean up unused CRC32 prototype and function

Gustavo Romero gromero at linux.vnet.ibm.com
Thu Nov 29 12:31:05 UTC 2018


Hi Lutz,

On 11/29/2018 08:10 AM, Schmidt, Lutz wrote:
> Hi Gustavo,
> nice cleanup! Thanks for investing the time. Build on linuxppc64 and linuxs390x went through smoothly.

Thanks a lot for testing and reviewing!


> The change looks good, by the way. But please note that I am NOT a reviewer.

Yeah, I'm aware :) I've put you as a (r)eviewer after Martin and pushed it.


Best regards,
Gustavo

> Thanks,
> Lutz
> 
> On 28.11.18, 19:39, "Gustavo Romero" <gromero at linux.vnet.ibm.com> wrote:
> 
>      Hi,
>      
>      Could the following change be reviewed please?
>      
>      It removes a prototype, generate_load_table_addr() (on PPC64), and an unused
>      function, kernel_crc32_2word() (on PPC64 and s390), in the CRC32 code.
>      
>      Bug   : https://bugs.openjdk.java.net/browse/JDK-8214451
>      Webrev: http://cr.openjdk.java.net/~gromero/8214451/v1/
>      
>      Thank you and best regards,
>      Gustavo
>      
>      
> 



More information about the hotspot-compiler-dev mailing list