[12] RFR(M): 8210215: C2 should optimize trichotomy calculations

Tobias Hartmann tobias.hartmann at oracle.com
Thu Oct 4 07:25:55 UTC 2018


Thanks Ian!

Looks like your patch only works for Integer/Long.compareTo by intrinsifying these methods but not
for the general case of a user provided compareTo method (which is what we want for value types).
Also, it aims to improve the hopefully rare case where we need to manifest the result value in a
register but not the case where we use it for branching.

I've linked it to my enhancement.

Best regards,
Tobias

On 03.10.2018 19:40, Ian Rogers wrote:
> This also seems related to:
> https://bugs.openjdk.java.net/browse/JDK-8137309
> which had some interesting discussion.
> 
> Thanks,
> Ian
> 
> On Wed, Oct 3, 2018 at 9:38 AM Tobias Hartmann <tobias.hartmann at oracle.com
> <mailto:tobias.hartmann at oracle.com>> wrote:
> 
>     Hi Vladimir,
> 
>     On 03.10.2018 17:15, Vladimir Kozlov wrote:
>     >> Here's the latest webrev that includes John's suggestions:
>     >> http://cr.openjdk.java.net/~thartmann/8210215/webrev.03/
>     <http://cr.openjdk.java.net/%7Ethartmann/8210215/webrev.03/>
>     >
>     > This looks good.
> 
>     Thank you. I've filed:
>     https://bugs.openjdk.java.net/browse/JDK-8211518
> 
>     Best regards,
>     Tobias
> 


More information about the hotspot-compiler-dev mailing list