RFR(M): 8209835: Aarch64: elide barriers on all volatile operations

[Andrew Dinn]

On 05/10/18 10:10, Roland Westrelin wrote:
> 
>>> http://cr.openjdk.java.net/~roland/8209835/webrev.00/
>>>
>>> This adds barrier elision support for all volatile operations that were
>>> not supported so far and extends the tests to cover all of them. I ran
>>> full jcstress successfully with this.
>> Yes, that looks good.
> 
> Thanks for the review.
> 
>> Did you also eyeball the generated code? I know jcstress ought to find
>> any bugs but it would be good to be doubly sure :-)
> 
> I didn't eyeball the code (there's a lot to check!). I extended tests to
> cover all combination of atomic operations/argument types. So at least,
> tests should guarantee that the right variant in the ad file is
> picked. Then, of course, all variants must be correctly implemented. For
> that, I checked a couple times that the right boolean flag was passed.
Yes, I noted the updates to the test code and they should ensure that
the generated code has the right instruction sequence.

That's an ok from me then.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander