[aarch64-port-dev ] RFR(M): 8209835: Aarch64: elide barriers on all volatile operations

Roland Westrelin rwestrel at redhat.com
Tue Oct 16 14:58:55 UTC 2018


> I have been eyeballing the code, and I see one problem:
>
>     public void testInt(int x, int i)
>     {
>         unsafe.compareAndExchangeInt(this, f_int_off, x, i);
>     }
>
> These methods don't test the return value at all. We really need
> to check the return value is correctly sign- or zero-extended and
> compressed Oops are correctly decoded.

Here is an updated webrev with your suggested test change:

http://cr.openjdk.java.net/~roland/8209835/webrev.01/

And the incremental webrev:

http://cr.openjdk.java.net/~roland/8209835/webrev.00-01/

The card marking store is not always before on after the cmpxchg itself
so I had to tweak the harness itself.

Roland.


More information about the hotspot-compiler-dev mailing list