[12] RFR(S): 8150552: Remove -XX:+AggressiveOpts

[Stefan Johansson]

Thanks for doing this removal,

The change looks good, just a few comments:
---
src/hotspot/share/runtime/arguments.cpp
1960   if (!FLAG_IS_DEFAULT(AutoBoxCacheMax)) {
1961     if (FLAG_IS_DEFAULT(EliminateAutoBox)) {
1962       FLAG_SET_DEFAULT(EliminateAutoBox, true);
1963     }
1964     if (FLAG_IS_DEFAULT(AutoBoxCacheMax)) {
1965       FLAG_SET_DEFAULT(AutoBoxCacheMax, 20000);
1966     }

Since we now only enter this block when AutoBoxCacheMax is not default, 
the check on line 1964 will never be true so this can be removed.
---
src/linux/doc/man/java.1
src/linux/doc/man/ja/java.1
src/bsd/doc/man/java.1
src/solaris/doc/sun/man/man1/java.1
src/solaris/doc/sun/man/man1/ja/java.1

I did a grep over the sources and found that AggressiveOpts is mentioned 
in these man-pages. Please remove these occurrences as well.
---

Thanks,
Stefan

On 2018-10-22 12:38, Tobias Hartmann wrote:
> Hi,
> 
> please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8150552
> http://cr.openjdk.java.net/~thartmann/8150552/webrev.00/
> 
> -XX:+AggressiveOpts was deprecated in JDK 11 and should be removed in JDK 12.
> 
> Best regards,
> Tobias
>