[12] RFR(S): 8177899: Tests fail due to code cache exhaustion on machines with many cores

[Doerr, Martin]

Hi Tobias,

thanks for implementing a limit.

I only wonder if using C2Compiler::initial_code_buffer_size() makes sense. Should we really start a C2 compiler thread for 5kB of code cache?
I'd prefer to use some feasible constant.

Best regards,
Martin


-----Original Message-----
From: hotspot-compiler-dev <hotspot-compiler-dev-bounces at openjdk.java.net> On Behalf Of Tobias Hartmann
Sent: Donnerstag, 25. Oktober 2018 08:49
To: Vladimir Kozlov <vladimir.kozlov at oracle.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: [12] RFR(S): 8177899: Tests fail due to code cache exhaustion on machines with many cores

Hi Vladimir,

On 24.10.18 18:18, Vladimir Kozlov wrote:
> Good. I think you need to check if CICompilerCount is FLAG_IS_DEFAULT when changing it.

The code is only executed if CICompilerCountPerCPU (which is disabled by default) is true. So either
CICompilerCountPerCPU was enabled by ergonomics (which only happens if CICompilerCount is default,
see TieredThresholdPolicy::initialize()) or the user explicitly enabled CICompilerCountPerCPU in
which case it should be fine to limit the maximum CICompilerCount that is set, right?

Thanks,
Tobias