RFR(M): 8212243: More gc interface tweaks for arraycopy and some other smaller changes in preparation for Shenandoah

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Oct 25 16:24:07 UTC 2018


I think this 'bs' is not used in arraycopynode.cpp:

+  BarrierSetC2* bs = BarrierSet::barrier_set()->barrier_set_c2();
    for (int i = 0; i < count; i++) {

It seems you wanted to pass it to new load() and store() methods. May be do that instead of loading it inside  these 
methods especially since in some placed they are called in loop.

Otherwise seems fine but it is hard for me to follow code now. We need to test it good. I will start testing after final 
webrev.

Thanks,
Vladimir

On 10/25/18 1:52 AM, Roland Westrelin wrote:
> 
> Hi Erik,
> 
> Here is a new webrev that should implement your recommendations:
> 
> http://cr.openjdk.java.net/~roland/8212243/webrev.02/
> 
> Roland.
> 


More information about the hotspot-compiler-dev mailing list