[12] RFR(S): 8213014: Crash in CompileBroker::make_thread due to OOM

Tobias Hartmann tobias.hartmann at oracle.com
Tue Oct 30 15:59:01 UTC 2018


Thanks, Vladimir.

Best regards,
Tobias

On 30.10.18 16:55, Vladimir Kozlov wrote:
> Looks good.
> 
> thanks,
> Vladimir
> 
> On 10/30/18 2:51 AM, Tobias Hartmann wrote:
>> Hi,
>>
>> please review the following patch:
>> https://bugs.openjdk.java.net/browse/JDK-8213014
>> http://cr.openjdk.java.net/~thartmann/8213014/webrev.00/
>>
>> The code in compileBroker.cpp:806 dereferences 'comp' which is NULL if creation of the sweeper
>> thread fails. I've also removed the 'compiler_thread' argument and replaced it by a "comp != NULL"
>> check. In addition, the calls to create_thread_oop() in init_compiler_sweeper_threads() need to
>> CHECK for exceptions.
>>
>> Thanks,
>> Tobias
>>


More information about the hotspot-compiler-dev mailing list