RFR (XS) 8210355: Minimal and Zero non-PCH builds fail after JDK-8207343 (Automate vtable/itable stub size calculation)

Tobias Hartmann tobias.hartmann at oracle.com
Tue Sep 4 11:09:07 UTC 2018


Hi Aleksey,

looks good to me and can be considered trivial.

Best regards,
Tobias

On 04.09.2018 12:28, Aleksey Shipilev wrote:
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8210355
> 
> Fix:
> 
> diff -r 3ee917225506 src/hotspot/share/code/vtableStubs.cpp
> --- a/src/hotspot/share/code/vtableStubs.cpp	Tue Sep 04 14:47:55 2018 +0800
> +++ b/src/hotspot/share/code/vtableStubs.cpp	Tue Sep 04 12:23:23 2018 +0200
> @@ -26,6 +26,7 @@
>  #include "code/vtableStubs.hpp"
>  #include "compiler/compileBroker.hpp"
>  #include "compiler/disassembler.hpp"
> +#include "logging/log.hpp"
>  #include "memory/allocation.inline.hpp"
>  #include "memory/resourceArea.hpp"
>  #include "oops/instanceKlass.hpp"
> 
> Seems like it is transitively included from somewhere (compiler?) in most configuration, but it
> breaks for Minimal and Zero non-PCH builds which are configured without C1/C2. Zero is still broken
> by other thing.
> 
> Testing: Linux x86_64 minimal builds
> 
> Thanks,
> -Aleksey
> 


More information about the hotspot-compiler-dev mailing list