RFR (XS) 8210357: Zero builds fail after JDK-8207343 (Automate vtable/itable stub size calculation)
Schmidt, Lutz
lutz.schmidt at sap.com
Tue Sep 4 13:14:56 UTC 2018
Sorry for the mess! Got the below mail just 10 minutes ago. May be related to internet connectivity issues here this morning.
Yes, pd_code_size_limit() should be gone on all platforms. I did a grep across the source tree to find all occurrences and obviously missed zero. Don't know why.
Regards,
Lutz
On 04.09.18, 12:33, "hotspot-compiler-dev on behalf of Aleksey Shipilev" <hotspot-compiler-dev-bounces at openjdk.java.net on behalf of shade at redhat.com> wrote:
Bug:
https://bugs.openjdk.java.net/browse/JDK-8210357
Seems like VtableStub::pd_code_size_limit is gone, and should be purged from Zero too.
Fix:
diff -r bc76fd44b029 src/hotspot/cpu/zero/vtableStubs_zero.cpp
--- a/src/hotspot/cpu/zero/vtableStubs_zero.cpp Tue Sep 04 12:28:12 2018 +0200
+++ b/src/hotspot/cpu/zero/vtableStubs_zero.cpp Tue Sep 04 12:30:21 2018 +0200
@@ -37,11 +37,6 @@
return NULL;
}
-int VtableStub::pd_code_size_limit(bool is_vtable_stub) {
- ShouldNotCallThis();
- return 0;
-}
-
int VtableStub::pd_code_alignment() {
ShouldNotCallThis();
return 0;
Testing: Linux x86_64 zero build
Thanks,
-Aleksey
More information about the hotspot-compiler-dev
mailing list