RFR: 8210158: Accessorize JFR getEventWriter() intrinsics

Erik Osterlund erik.osterlund at oracle.com
Tue Sep 4 17:55:30 UTC 2018


Hi Vladimir,

Thank you for the review.

/Erik

> On 4 Sep 2018, at 19:23, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> +1
> 
> Thanks,
> Vladimir
> 
>> On 9/4/18 3:36 AM, Rickard Bäckman wrote:
>> Looks good.
>> /R
>>> On 08/30, Erik Österlund wrote:
>>> Hi,
>>> 
>>> The JFR getEventWriter() intrinsics have code in C1 and C2 that manually
>>> resolves jobjects. This should go through the Access API to make sure the
>>> necessary GC barriers are inserted.
>>> 
>>> I noticed this in an attempt to move JNI handle processing out of the pause
>>> (among other things). It crashed in kitchensink.
>>> 
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8210158
>>> 
>>> Webrev:
>>> http://cr.openjdk.java.net/~eosterlund/8210158/webrev.00
>>> 
>>> I tested the patch by running it, together with a patch that moves out JNI
>>> handle processing outside of the pause, through hs-tier1-3, as well as
>>> running it through Kitchensink24H (as it originally crashed in kitchensink).
>>> 
>>> Thanks,
>>> /Erik



More information about the hotspot-compiler-dev mailing list