RFR: 8210158: Accessorize JFR getEventWriter() intrinsics

Erik Osterlund erik.osterlund at oracle.com
Tue Sep 4 20:00:56 UTC 2018


Hi Nils,

Thank you for the review!

/Erik

> On 4 Sep 2018, at 21:50, Nils Eliasson <nils.eliasson at oracle.com> wrote:
> 
> Looks good!
> 
> // Nils
> 
> 
>> On 2018-09-04 12:32, Erik Österlund wrote:
>> Hi,
>> 
>> Any more takers?
>> 
>> Full:
>> http://cr.openjdk.java.net/~eosterlund/8210158/webrev.01/
>> 
>> Thanks,
>> /Erik
>> 
>>> On 2018-08-30 17:06, Erik Österlund wrote:
>>> Hi Roland,
>>> 
>>> Thank you for the review.
>>> 
>>>> On 2018-08-30 13:21, Roland Westrelin wrote:
>>>> Hi Erik,
>>>> 
>>>>> http://cr.openjdk.java.net/~eosterlund/8210158/webrev.00
>>>> make_load() already calls _gvn.transform(), right?
>>> 
>>> Yes you are right. I will remove the redundant _gvn.transform call of the access_load; it is redundant indeed.
>>> 
>>>> You don't set MO_UNORDERED. Why is it not required?
>>> 
>>> MO_UNORDERED is the default MO of loads and stores. It is set up in the C2Access object using fixup_decorators() which sets sane defaults for various decorators, including MO.
>>> 
>>> Thanks,
>>> /Erik
>>> 
>>>> Roland.
>>> 
>> 
> 



More information about the hotspot-compiler-dev mailing list