RFR(S): 8210319: [s390]: Use of shift operators not covered by cpp standard

Schmidt, Lutz lutz.schmidt at sap.com
Mon Sep 10 14:20:01 UTC 2018


Thank you, Goetz!
With two positive reviews, and with the patch having been active in our nightly tests for several days, I'll go ahead and push.
Regards, Lutz

On 10.09.18, 16:15, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com> wrote:

    HI Lutz, 
    
    looks good to me, too.
    
    Thanks,
      Goetz.
    
    > -----Original Message-----
    > From: hotspot-compiler-dev <hotspot-compiler-dev-
    > bounces at openjdk.java.net> On Behalf Of Schmidt, Lutz
    > Sent: Dienstag, 4. September 2018 14:59
    > To: Doerr, Martin <martin.doerr at sap.com>; hotspot-compiler-
    > dev at openjdk.java.net
    > Subject: [CAUTION] Re: RFR(S): 8210319: [s390]: Use of shift operators not
    > covered by cpp standard
    > 
    > Hi Martin,
    > 
    > thanks for the review!
    > 
    > Regards,
    > 
    > Lutz
    > 
    > 
    > 
    > From: "Doerr, Martin (martin.doerr at sap.com)" <martin.doerr at sap.com>
    > Date: Tuesday, 4. September 2018 at 11:28
    > To: Lutz Schmidt <lutz.schmidt at sap.com>, "hotspot-compiler-
    > dev at openjdk.java.net" <hotspot-compiler-dev at openjdk.java.net>
    > Subject: RE: RFR(S): 8210319: [s390]: Use of shift operators not covered by
    > cpp standard
    > 
    > 
    > 
    > Hi Lutz,
    > 
    > 
    > 
    > looks good. Thanks for improving.
    > 
    > 
    > 
    > Best regards,
    > 
    > Martin
    > 
    > 
    > 
    > 
    > 
    > From: hotspot-compiler-dev <hotspot-compiler-dev-
    > bounces at openjdk.java.net> On Behalf Of Schmidt, Lutz
    > Sent: Dienstag, 4. September 2018 10:29
    > To: hotspot-compiler-dev at openjdk.java.net
    > Subject: RFR(S): 8210319: [s390]: Use of shift operators not covered by cpp
    > standard
    > 
    > 
    > 
    > Dear All,
    > 
    > 
    > 
    > may I please request reviews for this small, s390-only patch. It fixes some
    > shift operations which relied on behavior not covered by the language
    > standard.
    > 
    > Bug:    https://bugs.openjdk.java.net/browse/JDK-8210319
    > <https://bugs.openjdk.java.net/browse/JDK-8210319>
    > 
    > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8210319.00/
    > <http://cr.openjdk.java.net/~lucy/webrevs/8210319.00/>
    > 
    > 
    > 
    > Thank you!
    > 
    > Lutz
    > 
    > 
    
    



More information about the hotspot-compiler-dev mailing list