RFR(M): 8210497: [PPC64] Vector registers not saved across safepoint

[Lindenmaier, Goetz]

Hi Martin,

I had a look at your fix and it looks good.
I currently can't judge though whether even more
vector support is needed in some other place.
But this is not subject of this fix I guess.

Reviewed.

Best regards,
  Geotz.

PS: I would appreciate if you put the 'save_registers'
argument on a line of it's own whereever this is done for
all other arguments.  No new webrev needed.


From: Doerr, Martin
Sent: Freitag, 7. September 2018 18:12
To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-dev at openjdk.java.net>; Michihiro Horie (HORIE at jp.ibm.com) <HORIE at jp.ibm.com>; Gustavo Romero <gromero at linux.vnet.ibm.com>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Subject: RFR(M): 8210497: [PPC64] Vector registers not saved across safepoint

Hi,

we noticed that the RegisterSaver misses code to save and restore the vector registers on PPC64. I'd like to fix that.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8210497

Webrev:
http://cr.openjdk.java.net/~mdoerr/8210497_PPC64_save_CR/webrev.00/

This webrev already fixes the following tests when JDK-8208171 webrev.03 is applied:
compiler/runtime/safepoints/TestRegisterRestoring.java
compiler/runtime/Test7196199.java

I'll try to test the OopMap part. This may be tricky.

Best regards,
Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20180912/21dcff77/attachment.html>