RFR(S): JDK-8191339: [JVMCI] BigInteger compiler intrinsics on Graal.

[Patric Hedlin]

Hi Vladimir, Andrew,

Sorry for dropping this after vacation. The testing is a simplistic 
benchmark (soon to be... I hope) added to Graal (and some directed, a 
bit to ad hoc, testing not meant for up-streaming to Graal). I also used 
a simplified version of a more general JVMCI/VM test case for these 
options only, but it really does only exercise the JVMCI (not the option 
propagation in Graal or some other JVMCI "client"), making it less useful.

But in essence, Graal is the test-case.


On 2018-06-22 18:04, Vladimir Kozlov wrote:
> Hi Patric,
>
> Do you need Graal changes for this? Or it already has these intrinsics 
> and the only problem is these flags were not set in vm_version_x86.cpp?

No further changes have been made to Graal.

>
> Small note. In vm_version_x86.cpp previous code has already 
> COMPILER2_OR_JVMCI check. You can remove previous #endif and new 
> #ifdef. Also change comment for closing #endif at line 1080 to // 
> COMPILER2_OR_JVMCI
>
> 1080 #endif // COMPILER2

You are right (actually the intended webrev) and it should look correct 
now (just a tad old).

Best regards,
Patric
>
> What testing you did?
>
> Thanks,
> Vladimir
>
> On 6/21/18 8:26 AM, Patric Hedlin wrote:
>> Dear all,
>>
>> I would like to ask for help to review the following change/update:
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8191339
>>
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8191339/
>>
>>
>> 8191339: [JVMCI] BigInteger compiler intrinsics on Graal.
>>
>>      Enabling BigInteger intrinsics via JVMCI.
>>
>>
>>
>> Best regards,
>> Patric