RFR(XS) 8199885: [Graal] org.graalvm.compiler.core.test.CountedLoopTest fails with "ControlFlowAnchor should never be cloned in the same graph"

[Ekaterina Pavlova]

Graal team looked at the test failure log and it looks quite weird and rather "impossible" to reach that state.
I also did testing using latest jdk bits and no failures observed.
I would prefer to integrate the fix and file new bug in case new failures.

thanks,
-katya

On 8/14/18 11:49 AM, Vladimir Kozlov wrote:
> On 8/14/18 6:40 AM, Ekaterina Pavlova wrote:
>> On 8/13/18 12:25 PM, Vladimir Kozlov wrote:
>>> Katya,
>>>
>>> Did you confirmed that these tests are actually run in mach5 after these changes.
>>
>> yes, I do confirm.
>> However I started to observe intermittent failure of org.graalvm.compiler.core.test.CountedLoopTest today.
>> The failure is different. Let's postpone this change till I discuss new failure with Doug.
>> Please see other answers below.
>>
>>> I see conflicting '@requires' in test definition:
>>>
>>>    * @requires vm.opt.final.EnableJVMCI == true
>>> + * @requires !vm.graal.enabled
>>
>> well, they are not conflicting because vm.graal.enabled requires UseJVMCICompiler
>>
>>> The only runs when EnableJVMCI is specified are runs with Graal as JIT in which case second @requires will skip tests.
>>
>> we do run graal unit tests in 2 configurations:
>>
>> 1) graal-off: -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:-UseJVMCICompiler
> 
> I forgot about this mode. Yes, @require change is fine then.
>>
>> 2) graal-on:  -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+TieredCompilation -XX:+UseJVMCICompiler -Djvmci.Compiler=graal
>>
>> So, these tests will be run in first configuration and skipped in second one.
>>
>>> May be move these test into a special group to make sure to run them without Graal JIT but with JVMCI on.
>>
>> we already do it, graal unit tests are run using graal-off configuration as part of tier3 testing.
> 
> Got it.
> 
> Thanks,
> Vladimir
> 
>>
>> thanks,
>> -katya
>>
>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 8/13/18 5:26 AM, Ekaterina Pavlova wrote:
>>>> Hi All,
>>>>
>>>> please review the change which disables org.graalvm.compiler.core.test.* tests in Graal as JIT mode.
>>>> All these tests (except org.graalvm.compiler.core.test.tutorial.GraalTutorial and org.graalvm.compiler.core.test.StaticInterfaceFieldTest)
>>>> subclass GraalCompilerTest and were not designed to run in Graal as JIT mode.
>>>>
>>>> Doug also confirmed that disabling org.graalvm.compiler.core.test.tutorial.GraalTutorial and org.graalvm.compiler.core.test.StaticInterfaceFieldTest
>>>> is also the right way.
>>>>
>>>> Note, the tests will need to be modified/redesigned once Graal becomes default JIT compiler.
>>>>
>>>>
>>>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8199885
>>>>   webrev: http://cr.openjdk.java.net/~epavlova//8199885/webrev.00/index.html
>>>> testing: Run compiler/graalunit/CoreTest.java with enabled and disabled Graal. The test was skipped in case Graal was enabled and
>>>>           passed in case Graal was disabled.
>>>>
>>>> thanks,
>>>> -katya
>>>>
>>>>
>>