RFR: 8211100: hotspot C1 issue with comparing long numbers on x86 32-bit

[Tobias Hartmann]

Hi Dmitry,

this looks good to me but Igor (who implemented 8201447) should have a look as well.

Best regards,
Tobias

On 26.09.2018 09:04, Dmitry Cherepanov wrote:
> Hi Tobias,
> 
> Thanks for the review, updated patch avoids the additional move on x86_64 and includes the
> regression test.
> 
> http://cr.openjdk.java.net/~dcherepanov/8211100/webrev.01/
> <http://cr.openjdk.java.net/%7Edcherepanov/8211100/webrev.01/>
> 
> Dmitry
> 
>> On Sep 25, 2018, at 6:40 PM, Tobias Hartmann <tobias.hartmann at oracle.com
>> <mailto:tobias.hartmann at oracle.com>> wrote:
>>
>> Hi Dmitry,
>>
>> Shouldn't this at least be guarded by an #ifndef _LP64 to avoid the additional move on x86_64?
>>
>> Could you please add the regression test to the webrev? Or did this reproduce with other tests?
>>
>> Thanks,
>> Tobias
>>
>> On 25.09.2018 16:00, Dmitry Cherepanov wrote:
>>> Hello,
>>>
>>> Please review a patch that resolves issue in x86 32bit builds. It slightly adjusts the fix for
>>> JDK-8201447 (C1 does backedge profiling incorrectly) by creating a copy of the left operand and
>>> using it for incrementing backedge counter.
>>>
>>> JBS issue: https://bugs.openjdk.java.net/browse/JDK-8211100
>>> webrev: http://cr.openjdk.java.net/~dcherepanov/8211100/webrev.00/
>>> <http://cr.openjdk.java.net/%7Edcherepanov/8211100/webrev.00/>
>>>
>>> Thanks,
>>>
>>> Dmitry
>>>
>