RFR(M): 8210887: Tweak C2 gc api for arraycopy

[Vladimir Kozlov]

A LOT tests failed.

workspace/open/src/hotspot/share/opto/graphKit.cpp:1848), pid=24736, tid=15619
jib > #  assert(C->alias_type(call->adr_type()) == C->alias_type(hook_mem)) failed: call node must be constructed correctly

Vladimir

On 9/26/18 12:54 PM, Vladimir Kozlov wrote:
> Looks good but we need to test it hard. I submitted testing.
> 
> Thanks,
> Vladimir
> 
> On 9/25/18 1:42 AM, Tobias Hartmann wrote:
>> Hi Roland,
>>
>> okay, thanks for the clarifications.
>>
>> Best regards,
>> Tobias
>>
>> On 25.09.2018 10:37, Roland Westrelin wrote:
>>>
>>> Hi Tobias,
>>>
>>>> Looks good to me. I'm assuming the currently unused arguments of array_copy_requires_gc_barriers
>>>> will be used for Shenandoah? Why you need to distinguish between ArrayCopyPhase?
>>>
>>> Thanks for the view.
>>>
>>> Yes extra arguments are to be used by shenandoah.
>>>
>>> Generating barriers once parsing is over is not supported by all
>>> gcs. The shape of the barriers is sometimes too complicated to be
>>> emitted at igvn time.
>>>
>>> Roland.
>>>