RFR 8211272: x86_32 build failures after JDK-8210764 (Update avx512 implementation)
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri Sep 28 16:10:56 UTC 2018
Good. You can push it since it is trivial.
Thanks,
Vladimir
On 9/28/18 4:16 AM, Aleksey Shipilev wrote:
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8211272
>
> It is a trivial mistake: the braces got unbalanced when _LP64 is not defined, which is the case for
> x86_32 build. I would not bother to run it through jdk-submit.
>
> Fix:
>
> diff -r eb3e72f181af src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp
> --- a/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp Thu Sep 27 10:24:12 2018 +0200
> +++ b/src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp Fri Sep 28 13:08:20 2018 +0200
> @@ -2401,12 +2401,13 @@
> {
> #ifdef _LP64
> if (UseAVX > 2 && !VM_Version::supports_avx512vl()) {
> assert(tmp->is_valid(), "need temporary");
> __ vpandn(dest->as_xmm_double_reg(), tmp->as_xmm_double_reg(),
> value->as_xmm_double_reg(), 2);
> - } else {
> + } else
> #endif
> + {
> if (dest->as_xmm_double_reg() != value->as_xmm_double_reg()) {
> __ movdbl(dest->as_xmm_double_reg(), value->as_xmm_double_reg());
> }
> assert(!tmp->is_valid(), "do not need temporary");
> __ andpd(dest->as_xmm_double_reg(),
>
> Testing: x86_32 build, x86_64 build
>
> Thanks,
> -Aleksey
>
More information about the hotspot-compiler-dev
mailing list