RFR(S): 8211232: GraphKit::make_runtime_call() sometimes attaches wrong memory state to call

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Sep 28 16:43:41 UTC 2018


On 9/28/18 4:06 AM, Roland Westrelin wrote:
> 
> Hi Vladimir,
> 
> Thanks for looking at this.
> 
>> I understand that you want to avoid second reset_memory() and I agree.
>> But I concern about your code for setting input memory for call. Why not to pass narrow_mem from
>> memory(adr_type) to set_predefined_input_for_runtime_call() in this case and NULL in others and
>> check for NULL to select which memory to set.  memory(adr_type) will check for merge_mem.
> 
> Is this what you're suggesting?
> 
> http://cr.openjdk.java.net/~roland/8211232/webrev.00/

Yes. Does it work for you?

Thanks,
Vladimir

> 
> Roland.
> 


More information about the hotspot-compiler-dev mailing list