RFR (T/S) 8216551: GraalUnitTestLauncher should be executed as '@run driver'

dean.long at oracle.com dean.long at oracle.com
Fri Apr 5 00:26:16 UTC 2019


The timeout overrides, such as timeout=300, need to be preserved.

dl

On 4/4/19 12:50 PM, Ekaterina Pavlova wrote:
> Hi All,
>
>
> GraalUnitTestLauncher doesn't do real testing but spawns a new JVM to 
> run graal unit tests.
> There is no big sense to run GraalUnitTestLauncher in JDK under test 
> and with extra JVM flags
> used for real testing. So, the idea was to use '@run driver' to launch 
> GraalUnitTestLauncher.
>
> However GraalUnitTestLauncher has a code which look for 
> jdk.internal.vm.compiler and
> jdk.internal.vm.ci modules and this code will not work without 
> -XX:+EnableJVMCI. So, replacing
>  @run main/othervm compiler.graalunit.common.GraalUnitTestLauncher
> to
>  @run driver compiler.graalunit.common.GraalUnitTestLauncher
> doesn't not work.
>
> The current fix just removes '/othervm' so jtreg will be able to use 
> agent VMs from a pool
> to run compiler.graalunit.common.GraalUnitTestLauncher.
>
> Also updated 2 problem list files to match latest Graal bugs status:
>  test/hotspot/jtreg/ProblemList-graal.txt
>   test/jdk/ProblemList-graal.txt
>
>
> Please review the changes.
>
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8216551
>  webrev: 
> http://cr.openjdk.java.net/~epavlova//8216551/webrev.00/index.html
> testing: run graalunit tests in mach5
>
> thanks,
> -katya



More information about the hotspot-compiler-dev mailing list