RFR (T/S) 8216551: GraalUnitTestLauncher should be executed as '@run driver'

[Vladimir Kozlov]

On 4/5/19 9:00 AM, Ekaterina Pavlova wrote:
> On 4/4/19 2:37 PM, Vladimir Kozlov wrote:
>> Looks good. Should we also problem list tests for 8221514?
> 
> well, these failures are seen only when Graal is executed with -Xcomp flag.
> We have only ProblemList-graal.txt and ProblemList-Xcomp.txt, we don't have ProblemList-Graal-Xcomp.txt.
> I would prefer to don't create one more problem list file, Tom also said that 8221514 is going fixed soon.

Okay.

Thanks,
Vladimir

> 
> thanks,
> -katya
> 
>> Thanks,
>> Vladimir
>>
>> On 4/4/19 12:50 PM, Ekaterina Pavlova wrote:
>>> Hi All,
>>>
>>>
>>> GraalUnitTestLauncher doesn't do real testing but spawns a new JVM to run graal unit tests.
>>> There is no big sense to run GraalUnitTestLauncher in JDK under test and with extra JVM flags
>>> used for real testing. So, the idea was to use '@run driver' to launch GraalUnitTestLauncher.
>>>
>>> However GraalUnitTestLauncher has a code which look for jdk.internal.vm.compiler and
>>> jdk.internal.vm.ci modules and this code will not work without -XX:+EnableJVMCI. So, replacing
>>>   @run main/othervm compiler.graalunit.common.GraalUnitTestLauncher
>>> to
>>>   @run driver compiler.graalunit.common.GraalUnitTestLauncher
>>> doesn't not work.
>>>
>>> The current fix just removes '/othervm' so jtreg will be able to use agent VMs from a pool
>>> to run compiler.graalunit.common.GraalUnitTestLauncher.
>>>
>>> Also updated 2 problem list files to match latest Graal bugs status:
>>>   test/hotspot/jtreg/ProblemList-graal.txt
>>>    test/jdk/ProblemList-graal.txt
>>>
>>>
>>> Please review the changes.
>>>
>>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8216551
>>>   webrev: http://cr.openjdk.java.net/~epavlova//8216551/webrev.00/index.html
>>> testing: run graalunit tests in mach5
>>>
>>> thanks,
>>> -katya
>