RFR (M) 8222074: Enhance auto vectorization for x86

[Viswanathan, Sandhya]

Hi Vladimir,

Yes the intent was to have it like below:
        if ((vlen == 32 && UseAVX < 2) ||
            ((vlen == 64) && (VM_Version::supports_avx512bw() == false)))

I will look forward to the test results.

Best Regards,
Sandhya

-----Original Message-----
From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com] 
Sent: Monday, April 08, 2019 1:38 PM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; hotspot-compiler-dev at openjdk.java.net; Vladimir Kozlov <vladimir.kozlov at oracle.com>
Cc: Rukmannagari, Shravya <shravya.rukmannagari at intel.com>; Deshpande, Vivek R <vivek.r.deshpande at intel.com>
Subject: Re: RFR (M) 8222074: Enhance auto vectorization for x86

I tried to submit it for testing and spotted a build failure w/ clang:

.../src/hotspot/cpu/x86/x86.ad:1515:26: error: '&&' within '||' 
[-Werror,-Wlogical-op-parentheses]
              (vlen == 64) && (VM_Version::supports_avx512bw() == false))
              ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../src/hotspot/cpu/x86/x86.ad:1515:26: note: place parentheses around 
the '&&' expression to silence this warning
              (vlen == 64) && (VM_Version::supports_avx512bw() == false))
                           ^
              (                                                         )

I'll let you know how the testing is going.

Best regards,
Vladimir Ivanov

On 05/04/2019 18:18, Viswanathan, Sandhya wrote:
> Please find below a link to the webrev which enhances super-word auto 
> vectorization for x86.
> 
> The following additional operations are supported:
> 
> 1)Absolute for all data types
> 
> 2)Shifts for byte data types
> 
> 3)Shift right arithmetic for long data type
> 
> 4)Byte multiply
> 
> 5)Negate for float/double
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8222074
> 
> Webrev: http://cr.openjdk.java.net/~sviswanathan/8222074/webrev.00/
> 
> The compiler jtreg tests pass with UseAVX=0,1,2,3 and KNL.
> 
> Your review and comments are welcome.
> 
> Best Regards,
> 
> Sandhya
>