RFR(S): 8222103: [testbug] compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest may exceed VM limit

[Januschke, Peter]

Hi Igor,

the current implementation prints a message and then stops:

bool DirectivesStack::check_capacity(int request_size, outputStream* st) {
  if ((request_size + _depth) > CompilerDirectivesLimit) {
    st->print_cr("Could not add %i more directives. Currently %i/%i directives.", request_size, _depth, CompilerDirectivesLimit);
    return false;
  }
  return true;
}

Best regards

Peter

From: Igor Ignatyev <igor.ignatyev at oracle.com>
Sent: Montag, 8. April 2019 19:25
To: Januschke, Peter <peter.januschke at sap.com>
Cc: hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR(S): 8222103: [testbug] compiler/compilercontrol/jcmd/ClearDirectivesFileStackTest may exceed VM limit

Hi Peter,

I don't think it's a test bug, VM shouldn't stop execution if someone requests too many compiler directives, instead it should reject requests which will exceed its capacity.

-- Igor


On Apr 8, 2019, at 1:18 AM, Januschke, Peter <peter.januschke at sap.com<mailto:peter.januschke at sap.com>> wrote:

Hi,

I propose the following fix to the test mentioned in the subject:

Problem:
The test generates a random number of compiler directives, which might be greater than the value of CompilerDirectivesLimit. This causes the VM to stop execution upon the corresponding capacity check.

Fix: set CompilerDirectivesLimit to the max random number used.

http://cr.openjdk.java.net/~goetz/wr19/peter/8222103-01

https://bugs.openjdk.java.net/browse/JDK-8222103

Please review, and I please need a sponsor.

Best regards

Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190409/451f842e/attachment-0001.html>