RFR (XS) 8222397: x86_32 tests with UseSHA1Intrinsics SEGV due to garbled registers

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Apr 12 15:49:19 UTC 2019


Hi Aleksey,

With change you don't need push/pop limit which is rdi. And please add comment (false /*restoring*/).

Thanks,
Vladimir

On 4/12/19 6:31 AM, Aleksey, Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8222397
> 
> Fix:
>    http://cr.openjdk.java.net/~shade/8222397/webrev.01/
> 
> This basically does what is already done in generate_sha256_implCompress: save the registers before
> they are foobared by the runtime call.
> 
> Testing: tier{1,2} on Linux {x86_64, x86_32}, jdk-submit
> 


More information about the hotspot-compiler-dev mailing list