RFR (XS) 8222397: x86_32 tests with UseSHA1Intrinsics SEGV due to garbled registers

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Apr 15 15:51:41 UTC 2019


+1

Thanks
Vladimir

> On Apr 15, 2019, at 4:39 AM, Dmitry Samersoff <dms at samersoff.net> wrote:
> 
> Aleksey,
> 
>> New webrev:
>> http://cr.openjdk.java.net/~shade/8222397/webrev.02
> 
> Looks good to me.
> 
> -Dmitry
> 
>> On 14.04.2019 20:36, Aleksey Shipilev wrote:
>>> On 4/14/19 11:38 AM, Dmitry Samersoff wrote:
>>> Please, keep empty lines around handleSOERegisters.
>> 
>> I'd rather match the style, and make sure it leans to the same block as in other methods.
>> 
>>>> On 12.04.2019 18:49, Vladimir Kozlov wrote:
>>>> With change you don't need push/pop limit which is rdi. And please add
>>>> comment (false /*restoring*/).
>> 
>> Right! Updated.
>> 
>> New webrev:
>> http://cr.openjdk.java.net/~shade/8222397/webrev.02
>> 
>> Passes the same testing as the original patch.
>> 
>> -Aleksey
>> 



More information about the hotspot-compiler-dev mailing list