[13] RFR(T): 8222417: compiler/loopopts/TestOverunrolling.java times out

[Igor Ignatyev]

> On Apr 16, 2019, at 12:33 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
> 
> Hi Igor,
> 
> that's fine with me but then we should make sure to also change all the numerous other fixes that
> added '@requires !vm.graal.enabled' for the same reason. For example, JDK-8198924.
that's true,  and there is already a task to do that -- JDK-8207267. please note that JDK-8198924 was integrated before we introduced ProblemList-graal, so we didn't really have a choice when.
> 
> 
> I've created an umbrella bug for this:
> https://bugs.openjdk.java.net/browse/JDK-8222524
I guess we should close it as a dup of  8207267.
> 
> Here are the new webrevs:
> http://cr.openjdk.java.net/~thartmann/8222417/webrev.01/
> http://cr.openjdk.java.net/~thartmann/8222418/webrev.01/
both look good to me.

Thanks,
-- Igor
> 
> Thanks,
> Tobias
> 
> On 16.04.19 05:41, Igor Ignatyev wrote:
>> Hi Tobias,
>> 
>> although I agree that this test shouldn't be executed w/ Graal as JIT in the current setup, I don't
>> think '@requires !vm.graal.enabled' is a right choice here b/c this test still can/should be run w/
>> libgraal, so I'd suggest to put this test and other tests (e.g. TestScavengeRootsInCode.java) into
>> graal-specific problem list under an umbrella bug saying smth like 'Graal is very slow w/
>> -XX:-TieredCompilation -Xcomp'.
>> 
>> Thanks,
>> -- Igor
>> 
>>> On Apr 15, 2019, at 1:34 AM, Tobias Hartmann <tobias.hartmann at oracle.com
>>> <mailto:tobias.hartmann at oracle.com>> wrote:
>>> 
>>> Hi,
>>> 
>>> please review the following patch:
>>> https://bugs.openjdk.java.net/browse/JDK-8222417
>>> http://cr.openjdk.java.net/~thartmann/8222417/webrev.00/
>>> 
>>> The test sets -XX:-TieredCompilation -Xcomp and should therefore not be executed with Graal as JIT.
>>> Otherwise all Graal methods will be compiled by Graal itself running in interpreter mode which is
>>> very slow and causes the test to time out.
>>> 
>>> Thanks,
>>> Tobias
>>