RFR(XXS): 8222412: AARCH64: lse atomics encoding is not accepting zr as source

Dmitrij Pochepko dmitrij.pochepko at bell-sw.com
Thu Apr 18 16:54:36 UTC 2019


Hi all,

I'm withdrawing this patch and will rework it according to comments.

I'll use updated aarch64_asmtest.py instruction generator and all 
problems found by it will be fixed in one batch unless patch going to be 
too large for comfortable review.

Since it can only check positive cases, I'll also going to separately 
process negative cases, where incorrect parameters for instructions 
generation expected to be refused (mostly various missing asserts) as 
separate patch

Thanks,
Dmitrij
On 12/04/2019 6:24 PM, Dmitrij Pochepko wrote:
>
> Hi all,
>
> please review small fix for 8222412: AARCH64: lse atomics encoding is 
> not accepting zr as source
>
> webrev: http://cr.openjdk.java.net/~dpochepk/8222412/webrev.01/
>
> Current encoding for lse atomics hits assert when trying to use zr as 
> source register while it is allowed by spec. Current vm doesn't use 
> atomics with zr and this problem is not triggered.
>
>
> Testing:
>
> I generated lse atomics with zr as source register. No assert observed 
> with patched vm.
>
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8222412
>
> Thanks,
> Dmitrij
>
>


More information about the hotspot-compiler-dev mailing list