RFR(T): 8223142: Clean-up WS and CB.

Patric Hedlin patric.hedlin at oracle.com
Tue Apr 30 17:29:08 UTC 2019


Thanks Vladimir.

On 2019-04-30 18:58, Vladimir Ivanov wrote:
> Looks good.
>
> Would the following code benefit from more curly braces as well? :-)
>
> -  for( uint i = 0; i < _body.size(); i++ )
> -    if( _body[i]->is_Mem() )
> +  for (uint i = 0; i < _body.size(); i++)
> +    if (_body[i]->is_Mem())
>        return false;
>
We can always add more...

/Patric

> Best regards,
> Vladimir Ivanov
>
> On 30/04/2019 07:13, Patric Hedlin wrote:
>> ** Trivial but DISRUPTIVE. **
>>
>> Dear all,
>>
>> I would like to ask for help to review the following change/update:
>>
>> Issue:  https://bugs.openjdk.java.net/browse/JDK-8223142
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8223142/
>>
>> 8223142: Clean-up WS and CB.
>>
>>      Rid of all the different spacing/WS styles in "loopTransform.cpp".
>>
>>
>> Testing: Part of 8216137 (hs-tier1..4, hs-precheckin-comp, 
>> Kitchensink24h)
>>
>>
>> Best regards,
>> Patric
>>


More information about the hotspot-compiler-dev mailing list