[14] RFR(T): 8224957: C2 compilation fails with assert: Bad graph detected in build_loop_late

[Vladimir Kozlov]

Looks good.

Vladimir

On 8/4/19 11:09 PM, Tobias Hartmann wrote:
> Hi,
> 
> here's an updated webrev for JDK 14 that re-enables AggressiveUnboxing:
> http://cr.openjdk.java.net/~thartmann/8224957/webrev.01/
> 
> I'll push once the fix for 8228772 is in.
> 
> Thanks,
> Tobias
> 
> On 29.07.19 09:14, Tobias Hartmann wrote:
>> Roland, Vladimir, thanks for the reviews!
>>
>> Unfortunately, testing revealed another spurious crash (non-schedulable graph) that only happens
>> with my patch. I suspect that this issue is unrelated but only triggers due to the changes to
>> Node::dominates.
>>
>> Since I need more time to investigate and due to concerns about other potential issues that might be
>> triggered by this fix, I've decided to disable AggressiveUnboxing for JDK 13. I've filed 8228710 [1]
>> and will send a RFR soon.
>>
>> Best regards,
>> Tobias
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8228710
>>
>> On 27.07.19 03:36, Vladimir Kozlov wrote:
>>> +1
>>>
>>> Vladimir
>>>
>>> On 7/26/19 6:03 AM, Roland Westrelin wrote:
>>>>
>>>>> http://cr.openjdk.java.net/~thartmann/8224957/webrev.00/
>>>>
>>>> Looks good to me.
>>>>
>>>> Roland.
>>>>