RFR: 8229699 - [Graal] jck tests fail on windows with AOTed Graal

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Aug 15 18:59:29 UTC 2019


Looks good.

Thanks
Vladimir

> On Aug 15, 2019, at 11:19 AM, Bob Vandette <bob.vandette at oracle.com> wrote:
> 
> BUG:  https://bugs.openjdk.java.net/browse/JDK-8229699
> 
> A recent change (https://bugs.openjdk.java.net/browse/JDK-8227439) disabled UseAOT by default.
> UseAOT is automatically enabled if an AOTLibrary is specified but the check for UseAOT in os:init_2
> occurs before this happens.
> 
> This fix will install the exception handler if a library is added and the user hasn’t manually disabled AOT.
> 
> 
> diff --git a/src/hotspot/os/windows/os_windows.cpp b/src/hotspot/os/windows/os_windows.cpp
> --- a/src/hotspot/os/windows/os_windows.cpp
> +++ b/src/hotspot/os/windows/os_windows.cpp
> @@ -4122,7 +4122,7 @@
>  // in order to forward implicit exceptions from code in AOT
>  // generated DLLs.  This is necessary since these DLLs are not
>  // registered for structured exceptions like codecache methods are.
> -  if (UseAOT) {
> +  if (AOTLibrary != NULL && (UseAOT || FLAG_IS_DEFAULT(UseAOT))) {
>    topLevelVectoredExceptionHandler = AddVectoredExceptionHandler( 1, topLevelVectoredExceptionFilter);
>  }
> #endif
> 
> Bob.
> 



More information about the hotspot-compiler-dev mailing list