RFR(S): 8230061: # assert(mode == ControlAroundStripMined && use == sfpt) failed: missed a node

Roland Westrelin rwestrel at redhat.com
Wed Aug 28 13:57:58 UTC 2019


Hi Tobias,

Thanks for reviewing this.

> Why do you need a cast to Node* in node.cpp:711?

To cast const-ness out.

> And wouldn't it be better to bail out of the loop and return false if u == root?

Of course your right. I also switched to is_reachable_from_root()
(rather than unreachable) which feels more natural. Here is a new
webrev:

http://cr.openjdk.java.net/~roland/8230061/webrev.01/

Roland.


More information about the hotspot-compiler-dev mailing list