[14] RFR(M): 8229496: SIGFPE (division by zero) in C2 OSR compiled method

[Tobias Hartmann]

Hi Roland,

On 29.08.19 13:51, Roland Westrelin wrote:
>> http://cr.openjdk.java.net/~thartmann/8229496/webrev.00/
> 
> That looks good to me.

Thanks for the review.

> Have you verified performance?

Not yet, I wanted to wait for reviews. But I'll submit testing over the weekend.

> Wouldn't the code in CastLLNode::Ideal() after line 301 belong in
> CastLLNode::Value()? I realize you followed CastIINode::Ideal() which
> would need to be changed to.

Right, same in ConvI2LNode::Ideal. I've filed a separate enhancement for this:
https://bugs.openjdk.java.net/browse/JDK-8230382

Best regards,
Tobias